Re: [tablix-list] gtablix 0.0.9-9 development release

From: Tomaz Solc <tomaz.solcREMOVE@THISsiol.net>
Date: Fri Oct 21 2005 - 20:03:34 CEST

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

> I'm pleased to announce the new development release of Gtablix 0.0.9-9.

It looks great, however it wasn't working on my machine out of the box.
I've got this error, because on my machine "modulesref.xml" isn't
installed in the usual place.

Couldn't create file parser context for file
"/usr/share/tablix2/modulesref.xml": No such file or directory at
/usr/lib/perl5/XML/LibXML.pm line 435.
at modules/gtablix/modinfo.pm line 186

There is a patch attached that fixes this (it detects the path to
modulesref.xml file by running "tablix2 -v"). I think it would be best
if you would handle this path in the same way as you handle the path to
the fitness modules.

Another thing: there is a problem if more that one user is using Gtablix
 on one machine, because all instances use the same temporary directory
/tmp/gtablix. I believe it would be better to generate a random name for
this directory on start-up. I think perl already has some functions for
this (mktemp, tmpnam, tempfile or something similar)

Best regards
Tomaz Solc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDWS12sAlAlRhL9q8RArqTAJ9pcT8DIoqHIsUQK9HvG3sL0cHsdACdHvA/
uwNIGjfOUQW8ANsq1rskqkQ=
=HWeN
-----END PGP SIGNATURE-----

diff -rub gtablix/modules/gtablix/modinfo.pm gtablix-new/modules/gtablix/modinfo.pm
--- gtablix/modules/gtablix/modinfo.pm 2005-10-21 14:11:51.000000000 +0200
+++ gtablix-new/modules/gtablix/modinfo.pm 2005-10-21 19:51:50.000000000 +0200
@@ -183,7 +183,13 @@
 # $parser->load_ext_dtd(0);
 # $parser{skipDTD} = 1;
                 $parser->expand_entities(0);
- my $file_opened = $parser->parse_file("/usr/share/tablix2/modulesref.xml"); # build the XML
+ my $docpath;
+ my $temp = readpipe("LC_ALL=C ; tablix2 -v");
+ if ($temp=~/Module documentation available in (.*)/) {
+ $docpath=$1;
+ }
+
+ my $file_opened = $parser->parse_file("$docpath/modulesref.xml"); # build the XML
         my $root = $file_opened->getDocumentElement;
         my @modules = $root->getChildNodes;
         foreach my $module (@modules) {
Received on Fri Oct 21 20:03:53 2005

This archive was generated by hypermail 2.1.8 : Sat Oct 22 2005 - 06:28:48 CEST